Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #676

Merged
merged 27 commits into from
May 29, 2023
Merged

Unit testing #676

merged 27 commits into from
May 29, 2023

Conversation

gcglinton
Copy link
Contributor

Defined framework and patterns for how to do unit/functional testing using pytest.

Tests written include:

  • Retry (using both Disk and Redis)
  • DiskQueue
  • RedisQueue
  • part of NoDupe

There's also a Github Actions workflow defined, but it has not been tested yet.

gcglinton and others added 27 commits May 3, 2023 20:25
This tests all methods (private and public), as well as number of sub-cases for some methods.

Still need to confirm what's needed to run test suite other than `pytest`.
The "cleanup" test is broken because the DiskQueue's implemention is also broken (it's not clearing vars properly).
Had to re-build BaseOptions inside each test, lest it's vars/files get squashed or shared between test functions.
You previously had to be in the `tests` directory, but that wasn't going to work with some future changes (code coverage reporting)
Can now generage test result HTML and Junit reports, as well as code coverage reports.
https://pypi.org/project/pytest-cov/
https://pypi.org/project/pytest-html/

Can now mark tests as bugs, versus just having them fail (or xfail) before. https://pypi.org/project/pytest-bug/

Can now add test dependencies (Test A only runs if Test B passes): https://pypi.org/project/pytest-depends/
Not tested, but should work well.
The 'retry' tests have both Disk and Redis tests, so those were broken down into two steps, such that you could tell which one was failing.
Previously, asserts were being done against their values individually, but now both drivers are being compared against eachother *and* the desired value
Previously, asserts were being done against their values individually, but now both drivers are being compared against eachother *and* the desired value
@petersilva petersilva self-requested a review May 25, 2023 20:57
@petersilva
Copy link
Contributor

this is going to take a while to review...
I have to fix the flow tests with redis first.
then I can run these.

@gcglinton
Copy link
Contributor Author

Just looked at the redis tests again, and I don’t think the Redis service is starting properly.

I’ll have a look at it if I get time.

@petersilva petersilva merged commit cd34a5b into MetPX:v03_wip May 29, 2023
@gcglinton gcglinton deleted the UnitTesting branch June 5, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants