-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing #676
Merged
Merged
Unit testing #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests all methods (private and public), as well as number of sub-cases for some methods. Still need to confirm what's needed to run test suite other than `pytest`.
The "cleanup" test is broken because the DiskQueue's implemention is also broken (it's not clearing vars properly).
Had to re-build BaseOptions inside each test, lest it's vars/files get squashed or shared between test functions.
You previously had to be in the `tests` directory, but that wasn't going to work with some future changes (code coverage reporting)
Can now generage test result HTML and Junit reports, as well as code coverage reports. https://pypi.org/project/pytest-cov/ https://pypi.org/project/pytest-html/ Can now mark tests as bugs, versus just having them fail (or xfail) before. https://pypi.org/project/pytest-bug/ Can now add test dependencies (Test A only runs if Test B passes): https://pypi.org/project/pytest-depends/
Not tested, but should work well.
The 'retry' tests have both Disk and Redis tests, so those were broken down into two steps, such that you could tell which one was failing.
Previously, asserts were being done against their values individually, but now both drivers are being compared against eachother *and* the desired value
Previously, asserts were being done against their values individually, but now both drivers are being compared against eachother *and* the desired value
this is going to take a while to review... |
Just looked at the redis tests again, and I don’t think the Redis service is starting properly. I’ll have a look at it if I get time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defined framework and patterns for how to do unit/functional testing using pytest.
Tests written include:
There's also a Github Actions workflow defined, but it has not been tested yet.